fix(linkBubble): only render when needed

Prevents 503 requests during tests. See #5442. Signed-off-by: Max <[email protected]>
nextcloud · Apr 23, 2024 · d63c262 · d63c262
1 parent 6ba72ad
commit d63c262
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/src/plugins/LinkBubblePluginView.js b/src/plugins/LinkBubblePluginView.js
@@ -13,14 +13,6 @@ class LinkBubblePluginView {
  this.view = view
  this.plugin = plugin
  this.#editor = this.options.editor
-
- this.#component = new VueRenderer(LinkBubbleView, {
- parent: this.options.parent,
- propsData: {
- editor: this.options.editor,
- href: null,
- },
- })
  }
 
  addEventListeners() {
@@ -71,6 +63,14 @@ class LinkBubblePluginView {
  return
  }
 
+ this.#component ||= new VueRenderer(LinkBubbleView, {
+ parent: this.options.parent,
+ propsData: {
+ editor: this.options.editor,
+ href: null,
+ },
+ })
+
  this.tippy = tippy(editorElement, {
  duration: 100,
  getReferenceClientRect: null,
@@ -112,7 +112,7 @@ class LinkBubblePluginView {
  }
  const clientRect = referenceEl?.getBoundingClientRect()
 
- this.#component.updateProps({
+ this.#component?.updateProps({
  href: domHref(mark),
  })
 

diff --git a/src/tests/nodes/TaskItem.spec.js b/src/tests/nodes/TaskItem.spec.js
@@ -18,7 +18,7 @@ describe('TaskItem extension', () => {
  expect(taskItem.spec.toMarkdown).toBeDefined()
  })
 
- test('markdown syntax is preserved through editor', () => {
+ it('markdown syntax is preserved through editor', () => {
  // Invalid ones but should be syntactical unchanged
  expect(markdownThroughEditor('- [F] asd')).toBe('- [F] asd')
  expect(markdownThroughEditor('- [ [asd](sdf)')).toBe('- [ [asd](sdf)')