feat: Call notification popup #868
Draft
+224
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]> [skip ci]
ShGKme
force-pushed
the
feat/call-popup
branch
from
6c4a5d3
to
22075ff
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jancborchardt
requested changes
Nov 5, 2024
There was a problem hiding this comment.
Very nice! Just some small feedback:
- Considering the vertical whitespace between caller and buttons it possibly looks better to just make the modal square (I do appreciate your use of the golden spiral though ;)
- In Nextcloud and also on other calling systems like on iOS, Discord, etc the "Join call" button is usually on the right while "Decline" is on the left
On all the systems or only on Apple? |
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖼️ Screenshots
Design 1
Call notification popup is designed to have phone-call-like look.
With animation
Design 2
🚧 Tasks