-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: call notification popup (callbox) #868
Conversation
6c4a5d3
to
22075ff
Compare
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Just some small feedback:
- Considering the vertical whitespace between caller and buttons it possibly looks better to just make the modal square (I do appreciate your use of the golden spiral though ;)
- In Nextcloud and also on other calling systems like on iOS, Discord, etc the "Join call" button is usually on the right while "Decline" is on the left
On all the systems or only on Apple? |
a9d4a34
to
442abce
Compare
79ae4dd
to
60035f9
Compare
60035f9
to
4ad3b3e
Compare
* @param token - Conversation token | ||
*/ | ||
async function getCallParticipants(token: string) { | ||
const response = await axios.get<CallGetParticipantsForCallResponse>(generateOcsUrl('apps/spreed/api/v4/call/{token}', { token })) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be cheaper to fetch a single conversation and check:
.hasCall
if call is ongoing.participantFlags
if current user is connected to the call
But agree with doing it in a follow-up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nickvergessen is it actually cheaper?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let use this here /call
for now as it's what the clients also use. We could also do a specific cheapest endpoint in the future
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PS: releasing with CallGetParticipantsForCallResponse endpoint call is totally fine
we will have the first performance already available in the next release :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing blocking from me, tested in a group call
A new design is applied according to the discussion in chats
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
5fc832c
to
5e9f372
Compare
|
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
5e9f372
to
06186e6
Compare
☑️ Resolves
🖼️ Screenshots
Settings
Callbox
Animation
Position on the screen
Long name
Actions
Design 3:
Design 2
Design 1
Call notification popup is designed to have phone-call-like look.
With animation
🚧 Tasks