chore: ts support #755
Merged
chore: ts support #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShGKme
force-pushed
the
chore/ts-support
branch
from
c96ae09
to
0903dbc
Compare
ShGKme
force-pushed
the
chore/ts-support
branch
3 times, most recently
from
6e7cba6
to
0ac4b9d
Compare
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
Signed-off-by: Grigorii K. Shartsev <[email protected]>
ShGKme
force-pushed
the
chore/ts-support
branch
from
0ac4b9d
to
2a9b7ca
Compare
Antreesy
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Shall we also add it here? https://github.com/nextcloud/.github/tree/master/workflow-templates
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Adds improved TypeScript support:
vue-tscto typecheck Vue componentstypechecknpm script andtypecheck(elint-typescript`) CI actiontsconfig.jsonandglobal.d.tstypes@nextcloud/vuein v8 doesn't support Vue, so, it must be mocked with fake empty componentNo JS check atm. Migrating codebase to TS comes in follow-ups separated PRs.