Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes to enable unified push notifications in generic build. Signed… #4169

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gavine99
Copy link

@gavine99 gavine99 commented Sep 7, 2024

changes to allow a UnifiedPush distributor to deliver push messages in generic/f-droid build.

added a setting item to reset push notification registrations in case of issues with push (UnifiedPush distributor can sometimes get out of sync). this same setting item can also be used to reset firebase push in case of issues with it too.

a similar pr has been submitted for the nextcloud android client app - nextcloud/android#13516

this pr is related to, but not dependent on, 3 other pr's;
nextcloud server - nextcloud/server#47763 (to provide enhanced ability for multiple notification handlers)
nextcloud notifications app - nextcloud/notifications#2027 (to provide enhanced ability for multiple notification handlers)
3rd party unified push app - https://codeberg.org/NextPush/uppush/pulls/17 (to allow existing 3rd party nextcloud unifiedpush app to send nextcloud notifications via unifedpush)

altogether, the prs above provide an end-to-end solution for nextcloud to deliver push notifications via UnifiedPush.

@@ -303,6 +303,9 @@ dependencies {
implementation 'com.github.nextcloud.android-common:ui:0.23.0'
implementation 'com.github.nextcloud-deps:android-talk-webrtc:121.6167.0'

// unified push library for generic flavour
genericImplementation 'org.codeberg.UnifiedPush:android-connector:2.4.0'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
genericImplementation 'org.codeberg.UnifiedPush:android-connector:2.4.0'
genericImplementation 'org.unifiedpush.android:connector:2.5.0'

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants