Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement text formatting via markdown #3155

Merged
merged 3 commits into from
Jul 10, 2023

Conversation

AndyScherzinger
Copy link
Member

@AndyScherzinger AndyScherzinger commented Jul 6, 2023

Resolves #3154

πŸ–ΌοΈ Screenshots

🏚️ Before 🏑 After
Screenshot_20230710_105102 Screenshot_20230710_104336

Note
Items aren't interactive, so you can't tick of checkboxes ;)

🚧 TODO

  • apply to different messages
  • unify formatting code for reuse

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • πŸ”– Capability is checked or not needed
  • πŸ”™ Backport requests are created or not needed: /backport to stable-xx.x
  • πŸ“… Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@AndyScherzinger AndyScherzinger added the 2. developing Work in progress label Jul 6, 2023
@AndyScherzinger AndyScherzinger added this to the 17.1.0 milestone Jul 6, 2023
@AndyScherzinger AndyScherzinger self-assigned this Jul 6, 2023
@AndyScherzinger AndyScherzinger force-pushed the feature/3154/chatTextFormatting branch 9 times, most recently from 422f00f to e812cef Compare July 7, 2023 17:52
@AndyScherzinger AndyScherzinger added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 7, 2023
@AndyScherzinger AndyScherzinger marked this pull request as ready for review July 7, 2023 17:55
@AndyScherzinger AndyScherzinger force-pushed the feature/3154/chatTextFormatting branch from e812cef to 80e51ed Compare July 7, 2023 17:58
@AndyScherzinger AndyScherzinger force-pushed the feature/3154/chatTextFormatting branch from 80e51ed to fa8fd7b Compare July 10, 2023 07:38
@SystemKeeper
Copy link

Hey @AndyScherzinger, code blocks with 3 back ticks are just rendered as a block with monospaced font, right?

@AndyScherzinger
Copy link
Member Author

Hey @AndyScherzinger, code blocks with 3 back ticks are just rendered as a block with monospaced font, right?

Yes.currently I don't plan to add support for syntax highlighting that seems to be just over the top from my point of view πŸ‘

@mahibi
Copy link
Collaborator

mahibi commented Jul 10, 2023

great πŸ‘ πŸ‘

one random test where the time is not correctly aligned:

grafik

@mahibi
Copy link
Collaborator

mahibi commented Jul 10, 2023

not sure how much work it might be to improve tables? ...

grafik

@AndyScherzinger
Copy link
Member Author

I'd remove tables for the moment - from my point of view (iOS won't support it either)
I'll look into the timestamp alignment πŸ‘

Signed-off-by: Andy Scherzinger <[email protected]>
@AndyScherzinger
Copy link
Member Author

one random test where the time is not correctly aligned:
not sure how much work it might be to improve tables? ...

@mahibi, I removed table rendering and the time alignment issue is also present on master (this is due to the parent layout component (flex box) :( So I would ignore that one.

Screenshot_20230710_175127

@github-actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings9393
Errors00

SpotBugs

CategoryBaseNew
Correctness99
Dodgy code164164
Internationalization55
Malicious code vulnerability33
Performance99
Security22
Total192192

@github-actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3155-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@AndyScherzinger AndyScherzinger merged commit f913ccb into master Jul 10, 2023
14 of 15 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feature/3154/chatTextFormatting branch July 10, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request feature: πŸ—¨οΈ chat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basic text formatting for chat messages
3 participants