Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not compare read/typing privacy with constants casted to string #13700

Merged
merged 3 commits into from
Nov 6, 2024
Merged

fix: do not compare read/typing privacy with constants casted to string #13700

merged 3 commits into from
Nov 6, 2024
+57 −33

Commits on Nov 6, 2024

  1. fix(settings): do not compare read/typing privacy with constants cast… 

    …ed to string

Signed-off-by: Maksim Sukharev <[email protected]>
    @Antreesy @nickvergessen
    Antreesy authored and nickvergessen committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    db9bf43 View commit details
    Browse the repository at this point in the history

  2. fix(settings): Make sure to only accept numeric strings 

    Signed-off-by: Joas Schilling <[email protected]>
    @nickvergessen
    nickvergessen committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    4e0bc40 View commit details
    Browse the repository at this point in the history

  3. fix(settings): Add tests for setting integers 

    Signed-off-by: Joas Schilling <[email protected]>
    @nickvergessen
    nickvergessen committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    0a67ab1 View commit details
    Browse the repository at this point in the history