feat(calls): Allow moderators to download a call participants list #13519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
2. developing
enhancement
feature: api 🛠️
nickvergessen
force-pushed
the
feat/13453/download-call-participants
branch
3 times, most recently
from
a6b1e79
to
fa97223
Compare
3 tasks
nickvergessen
force-pushed
the
feat/13453/download-call-participants
branch
from
fa97223
to
18c12a9
Compare
nickvergessen
commented
Oct 15, 2024
| } | ||
|
|
||
| if ($format !== 'csv') { | ||
| // FIXME Remove once pdf was implemented. |
There was a problem hiding this comment.
Note: Currently only CSV is functional
|
/backport to stable30 |
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
feat/13453/download-call-participants
branch
from
18c12a9
to
5be3f06
Compare
DorraJaouad
approved these changes
Oct 15, 2024
Comment on lines
+149
to
+153
| fputcsv($output, [ | ||
| 'name', | ||
| 'type', | ||
| 'identifier', | ||
| ]); |
There was a problem hiding this comment.
Should we prettify the output? (headers with capital letters)
There was a problem hiding this comment.
We can do that for the PDF version later. For the CSV I would keep it "ugly"
There was a problem hiding this comment.
as-is should be less confusing for later use (like import)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🛠️ API Checklist
🚧 Tasks
🏁 Checklist
docs/has been updated or is not required