Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace v-tooltip with native title #13423

Merged
merged 2 commits into from
Oct 2, 2024
Merged

fix: replace v-tooltip with native title #13423

merged 2 commits into from
Oct 2, 2024

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

  • Fix leftovers from v-tooltip usage

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image
image image
image image
image image
image image
image image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team

@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Sep 30, 2024
@Antreesy Antreesy self-assigned this Sep 30, 2024
DorraJaouad
DorraJaouad reviewed Oct 1, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also rename
MessageButtonsBar.vue : readInfo.*tooltip (so are in Message.vue
MessageBody.vue: sendingErrorIconTooltip | loadingIconTooltip | readInfo.*tooltip
NewMessageAudioRecorder.vue: *RecordingTooltip
TopBarMediaControls.vue

src/components/CallView/shared/VideoBottomBar.vue Outdated Show resolved Hide resolved
src/components/CallView/shared/VideoBottomBar.vue Outdated Show resolved Hide resolved
@Antreesy
fix: rename *Tooltip to *Title
75e13a7 
- get rid of object fields reassigning in TopBarMediaControls

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy
Copy link
Contributor Author

Antreesy commented Oct 1, 2024

Checked
image

DorraJaouad
DorraJaouad approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good

@Antreesy Antreesy merged commit 79805c8 into main Oct 2, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/noid/reduce-tooltips-usage branch October 2, 2024 10:42
@Antreesy
Copy link
Contributor Author

Antreesy commented Oct 2, 2024

/backport to stable30

@backportbot backportbot bot mentioned this pull request Oct 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@ShGKme ShGKme ShGKme approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review accessibility feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.
3 participants
@Antreesy @ShGKme @DorraJaouad