Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: decrease chat messages 'reading width' #13394

Merged
merged 1 commit into from
Sep 30, 2024
Merged

style: decrease chat messages 'reading width' #13394

merged 1 commit into from
Sep 30, 2024

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

  • Decrease max width of text message to 750px (50em)
  • Most resources recommended from 60 to 80 characters per line, example: https://baymard.com/blog/line-length-readability
  • I managed now to fit 113 characters with normal font (91 with dyslexic font)

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
75ch (article) image
35em (article) image
600px (stable29) image
⚠️ 50em (this PR) image
⚠️ 50em (this PR) image
70em (stable30) image
this PR + diff image

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Sep 25, 2024
@Antreesy Antreesy self-assigned this Sep 25, 2024
@Antreesy Antreesy merged commit c3ea66c into main Sep 30, 2024
46 checks passed
@Antreesy Antreesy deleted the style/noid/chat-width branch September 30, 2024 13:07
@Antreesy
Copy link
Contributor Author

/backport to stable30

@backportbot backportbot bot mentioned this pull request Sep 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

Assignees

@Antreesy Antreesy

Labels
accessibility design feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
🖤 Next Major (31)
Development

Successfully merging this pull request may close these issues.
3 participants
@Antreesy @marcoambrosini @DorraJaouad