Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable30] feat(codingstandard): Update coding-standard to 1.3.1 #13347

Merged
merged 2 commits into from
Sep 19, 2024
Merged

[stable30] feat(codingstandard): Update coding-standard to 1.3.1 #13347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78620a7
feat(codingstandard): Update coding-standard to 1.3.1
nickvergessen Sep 19, 2024
7f20f46
fix(codingstandard): Apply autofixes
nickvergessen Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/Command/Developer/UpdateDocs.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ protected function getDocumentation(Command $command): string {
$command->getUsages()
),
function ($carry, $usage) {
return $carry.'* `' . $usage . '`' . "\n";
return $carry . '* `' . $usage . '`' . "\n";
}
);
$doc .= $this->describeInputDefinition($command);
Expand Down
1 change: 0 additions & 1 deletion lib/Signaling/Responses/DialOut.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ final class DialOut {
public function __construct(
/** @var non-empty-string|null */
public ?string $callId = null,

public ?DialOutError $error = null,
) {
}
Expand Down
2 changes: 0 additions & 2 deletions lib/Signaling/Responses/DialOutError.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,7 @@ final class DialOutError {
public function __construct(
/** @var non-empty-string */
public ?string $code,

public ?string $message = null,

/** @var ?array{attendeeId: int} */
public ?array $details = null,
) {
Expand Down
1 change: 0 additions & 1 deletion lib/Signaling/Responses/Response.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ final class Response {
public function __construct(
/** @var non-empty-string */
public string $type,

/** @var DialOut|null */
public ?DialOut $dialOut,
) {
Expand Down
2 changes: 1 addition & 1 deletion tests/php/bootstrap.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
if (!defined('PHPUNIT_RUN')) {
define('PHPUNIT_RUN', 1);
}
require_once __DIR__.'/../../../../lib/base.php';
require_once __DIR__ . '/../../../../lib/base.php';
\OC::$loader->addValidRoot(\OC::$SERVERROOT . '/tests');
\OC_App::loadApp('spreed');
if (!class_exists('\PHPUnit\Framework\TestCase')) {
Expand Down
2 changes: 1 addition & 1 deletion vendor-bin/csfixer/composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@
},
"require-dev": {
"friendsofphp/php-cs-fixer": "^3.62.0",
"nextcloud/coding-standard": "^1.2.3"
"nextcloud/coding-standard": "^1.3.1"
}
}
61 changes: 54 additions & 7 deletions vendor-bin/csfixer/composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading