fix(Call): introduce intermediary phase before joining call #13329
+319
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DorraJaouad
commented
Sep 17, 2024
Antreesy
reviewed
Sep 18, 2024
| @@ -321,27 +321,29 @@ const mutations = { | |||
| if (state.inCall[token] && state.inCall[token][sessionId]) { | |||
| Vue.delete(state.inCall[token], sessionId) | |||
| } | |||
|
|
|||
| if (state.connecting[token] && state.connecting[token][sessionId]) { | |||
There was a problem hiding this comment.
I think we can keep this resetting (in case it survives somehow). Maybe via commit('finishedConnecting')?
There was a problem hiding this comment.
Still missing for leaveCall
|
DorraJaouad
force-pushed
the
fix/call-joining
branch
from
f700fed
to
1191f69
Compare
It was because |
DorraJaouad
force-pushed
the
fix/call-joining
branch
from
1191f69
to
40205de
Compare
DorraJaouad
force-pushed
the
fix/call-joining
branch
from
40205de
to
0d90b15
Compare
DorraJaouad
force-pushed
the
fix/call-joining
branch
from
ecc00b8
to
005a3b0
Compare
…t. It's only received when using internal server. Replace them with events from the base class so we make sure it's always received. Also, add a new event for failed joining Signed-off-by: DorraJaouad <[email protected]>
…nCall, connecting, connection failed) Signed-off-by: DorraJaouad <[email protected]>
…roduce a failed join message dialog. Signed-off-by: DorraJaouad <[email protected]>
Signed-off-by: DorraJaouad <[email protected]>
DorraJaouad
force-pushed
the
fix/call-joining
branch
from
005a3b0
to
00f74c3
Compare
…l AND wait for participants list Signed-off-by: DorraJaouad <[email protected]>
DorraJaouad
force-pushed
the
fix/call-joining
branch
from
00f74c3
to
855da4f
Compare
Antreesy
reviewed
Nov 4, 2024
src/components/TopBar/CallButton.vue
Outdated
| :type="startCallButtonType" | ||
| @click="handleClick"> | ||
| <template #icon> | ||
| <IconPhoneDial v-if="isPhoneRoom" :size="20" /> | ||
| <NcLoadingIcon v-if="isJoiningCall || loading" /> |
There was a problem hiding this comment.
Also add spinner when leaving conversation (loading is true)?
| @@ -321,27 +321,29 @@ const mutations = { | |||
| if (state.inCall[token] && state.inCall[token][sessionId]) { | |||
| Vue.delete(state.inCall[token], sessionId) | |||
| } | |||
|
|
|||
| if (state.connecting[token] && state.connecting[token][sessionId]) { | |||
There was a problem hiding this comment.
Still missing for leaveCall
Signed-off-by: DorraJaouad <[email protected]>
Signed-off-by: DorraJaouad <[email protected]>
Signed-off-by: DorraJaouad <[email protected]>
Signed-off-by: DorraJaouad <[email protected]>
Signed-off-by: DorraJaouad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
Before
Recording.2024-09-17.160718.mp4
After
Recording.2024-09-17.160913.mp4
🏁 Checklist