Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(changelog): Don't check the user changelog twice #13290

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

nickvergessen
Copy link
Member

☑️ Resolves

  • Related
    grafik

Explanation

There was a simple race condition previously with 2 requests R1 and R2:

  • R1: handle()
  • R1: userHasNewChangelog() compares X0 with count()
  • R2: handle()
  • R2: userHasNewChangelog() compares X0 with count()
  • R1: updateChangelog()
  • R1: getChangelogForUser() reads X0
  • R1: setUserValue() sets X1 with precondition X0
  • R2: updateChangelog()
  • R2: getChangelogForUser() reads X1 💥
  • R2: setUserValue() sets X1 with precondition X1

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@nickvergessen nickvergessen added 3. to review bug feature: chat 💬 Chat and system messages feature: api 🛠️ OCS API for conversations, chats and participants labels Sep 13, 2024
@nickvergessen nickvergessen added this to the 🖤 Next Major (31) milestone Sep 13, 2024
@nickvergessen nickvergessen self-assigned this Sep 13, 2024
@nickvergessen
Copy link
Member Author

/backport to stable30

Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickvergessen nickvergessen merged commit 5a047fc into main Sep 23, 2024
68 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/duplicate-changelog branch September 23, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug feature: api 🛠️ OCS API for conversations, chats and participants feature: chat 💬 Chat and system messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants