Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MessageList): rewrite CSS layout of chat #12823

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jul 26, 2024

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image
image image

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

Copy link
Member

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks pretty compact. I'd suggest that these changes be implemented when there's a lack of horizontal space, since we discussed this mostly in the context of the chat during calls.

How about these values are enforced only when the width of the screen falls below the max line width (which I believe is around 700px)?

@Antreesy Antreesy force-pushed the fix/noid/chat-layout-rewrite branch from 878e2a0 to b3e0d29 Compare July 27, 2024 17:58
@Antreesy
Copy link
Contributor Author

only when the width of the screen falls below the max line width

Some general rework was needed here anyway. Applied reduced padding for sidebar chats only (that is Files integration and during calls)

@ShGKme

This comment was marked as resolved.

@nickvergessen

This comment was marked as resolved.

@Antreesy

This comment was marked as resolved.

@Antreesy
Copy link
Contributor Author

Antreesy commented Aug 1, 2024

Dropped most of the conditional size changes to establish correct grid layout first. Let's discuss this part, then continue with chat appearance in sidebars

@Antreesy Antreesy force-pushed the fix/noid/chat-layout-rewrite branch from aa55862 to b50c2fe Compare August 1, 2024 17:33
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go 🦅

…-limited scroller content

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy force-pushed the fix/noid/chat-layout-rewrite branch from a59c24a to 7b9c399 Compare August 5, 2024 10:50
@Antreesy Antreesy merged commit 024871f into main Aug 5, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/noid/chat-layout-rewrite branch August 5, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants