-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(MessageList): rewrite CSS layout of chat #12823
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Looks pretty compact. I'd suggest that these changes be implemented when there's a lack of horizontal space, since we discussed this mostly in the context of the chat during calls.
How about these values are enforced only when the width of the screen falls below the max line width (which I believe is around 700px)?
878e2a0
to
b3e0d29
Compare
Some general rework was needed here anyway. Applied reduced padding for sidebar chats only (that is Files integration and during calls) |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
src/components/MessagesList/MessagesGroup/Message/MessagePart/MessageBody.vue
Outdated
Show resolved
Hide resolved
src/components/MessagesList/MessagesGroup/Message/MessagePart/MessageBody.vue
Outdated
Show resolved
Hide resolved
b9e6e42
to
aa55862
Compare
Dropped most of the conditional size changes to establish correct grid layout first. Let's discuss this part, then continue with chat appearance in sidebars |
src/components/MessagesList/MessagesGroup/Message/MessagePart/MessageBody.vue
Outdated
Show resolved
Hide resolved
aa55862
to
b50c2fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go 🦅
…-limited scroller content Signed-off-by: Maksim Sukharev <[email protected]>
a59c24a
to
7b9c399
Compare
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
Tip
For visual diff use https://www.diffchecker.com/image-compare/
🏁 Checklist