Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AdminSettings): hide secrets in password fields #12812

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jul 25, 2024

☑️ Resolves

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
image image
. image
. image
. image

🚧 Tasks

  • Replace Text fields with password fields for shared secrets
  • Add autocomplete="new-password" to not save the password
    • Completely disable is not possible with type="password", forced by web-browsers
  • Add names just in case, so browsers and tools may know these are not user passwords and are different values

🏁 Checklist

  • 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
  • 🖥️ Tested with Desktop client or should not be risky for it
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

@ShGKme ShGKme added 3. to review feature: settings ⚙️ Settings and config related issues feature: frontend 🖌️ "Web UI" client labels Jul 25, 2024
@ShGKme ShGKme added this to the 💙 Next Major (30) milestone Jul 25, 2024
@ShGKme ShGKme requested a review from Antreesy July 25, 2024 09:17
@ShGKme ShGKme self-assigned this Jul 25, 2024
@ShGKme ShGKme force-pushed the fix/admin-settings--hide-secrets branch from ca0ff46 to 80e562b Compare July 25, 2024 09:41
@Antreesy Antreesy merged commit 712f12f into main Jul 25, 2024
46 checks passed
@Antreesy Antreesy deleted the fix/admin-settings--hide-secrets branch July 25, 2024 10:15
@ShGKme
Copy link
Contributor Author

ShGKme commented Jul 29, 2024

/backport to stable29

@ShGKme
Copy link
Contributor Author

ShGKme commented Jul 29, 2024

/backport to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants