chore(NcNoteCard): use custom icon slot #11545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 tasks
|
if I remember, @szaimen has some thoughts on this component design |
Antreesy
reviewed
Feb 7, 2024
Yes, please make it look like this: nextcloud-libraries/nextcloud-vue#4894 (comment) |
So to indicate the requested changes (cc @szaimen) :
|
The chevron should only be shown if there is a longer message available so that you can hide it. The short message should always be shown. |
Antreesy
reviewed
Feb 8, 2024
DorraJaouad
force-pushed
the
chore/noid/use-custom-icon-slot
branch
from
a284fc3
to
a73efd5
Compare
Antreesy
approved these changes
Feb 8, 2024
|
May I ask how it looks now? |
Screenshots seem to be actual, though you had different border-radius on your sketch? Screencast.from.08.02.2024.23.20.22.webm |
|
Thanks @Antreesy! Before merging, please fix the look of the left side. Please compare:
|
Signed-off-by: DorraJaouad <[email protected]>
DorraJaouad
force-pushed
the
chore/noid/use-custom-icon-slot
branch
from
a73efd5
to
5da4fa5
Compare
szaimen
approved these changes
Feb 9, 2024
|
/backport to stable28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
@nextcloud/vue: library bump follow-ups #11494🖌️ UI Checklist
🖼️ Screenshots / Screencasts
I just reversed the Chevron because the div gets up and space was reduced.
🏁 Checklist