Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Message) - support Markdown in messages #10063

Merged
merged 1 commit into from
Jul 27, 2023
Merged

feat(Message) - support Markdown in messages #10063

merged 1 commit into from
Jul 27, 2023

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jul 27, 2023 •
edited
Loading

☑️ Resolves

🖼️ Screenshots

🏚️ Before 🏡 After
image image
image image
image image
image image
image image
image image

🚧 Tasks

  • Styles for markdown elements should be defiined
  • Visual check
  • Code review

🏁 Checklist

@Antreesy Antreesy added this to the 💜 Next Major (28) milestone Jul 27, 2023
@Antreesy Antreesy self-assigned this Jul 27, 2023
@Antreesy
Copy link
Contributor Author

DorraJaouad
DorraJaouad approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visually tested and it works.

@Antreesy Antreesy mentioned this pull request Jul 27, 2023
Closed
@Antreesy Antreesy force-pushed the feat/9949/frontend-markdown-support branch from 1a899cf to e646536 Compare July 27, 2023 17:58
@Antreesy Antreesy marked this pull request as ready for review July 27, 2023 18:01
@Antreesy Antreesy changed the title [WIP] feat(Message) - support Markdown in messages feat(Message) - support Markdown in messages Jul 27, 2023
@Antreesy Antreesy enabled auto-merge July 27, 2023 18:01
@Antreesy Antreesy merged commit 9b92330 into master Jul 27, 2023
19 checks passed
@Antreesy Antreesy deleted the feat/9949/frontend-markdown-support branch July 27, 2023 19:23
@Antreesy
Copy link
Contributor Author

Antreesy commented Aug 2, 2023

/backport to stable27

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Aug 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees

@Antreesy Antreesy

Labels
2. developing enhancement feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client
Projects
None yet
Milestone
v18.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

Markdown support - Frontend
3 participants
@Antreesy @nickvergessen @DorraJaouad