Merge pull request #13344 from nextcloud/feat/noid/add-rector

🤖 techdebt: Add PHP rector

.github/dependabot.yml

@@ -55,6 +55,7 @@ updates:
     - "/vendor-bin/mozart"
     - "/vendor-bin/phpunit"
     - "/vendor-bin/psalm"
+    - "/vendor-bin/rector"
   commit-message:
     prefix: "ci"
     include: "scope"

composer.json

@@ -20,6 +20,8 @@
 		"cs:fix": "php-cs-fixer fix",
 		"lint": "find . -name \\*.php -not -path './vendor/*' -not -path './vendor-bin/*' -not -path './lib/Vendor/*' -not -path './build/*' -not -path './tests/integration/vendor/*' -print0 | xargs -0 -n1 php -l",
 		"openapi": "generate-spec --verbose && (npm run typescript:generate || echo 'Please manually regenerate the typescript OpenAPI models')",
+		"rector:check": "rector --dry-run",
+		"rector:fix": "rector",
 		"psalm": "psalm --threads=1",
 		"psalm:dev": "psalm --no-cache --threads=$(nproc)",
 		"psalm:update-baseline": "psalm --threads=1 --update-baseline --set-baseline=tests/psalm-baseline.xml",

rector.php

@@ -0,0 +1,24 @@
+<?php
+
+declare(strict_types=1);
+/**
+ * SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+
+use Nextcloud\Rector\Set\NextcloudSets;
+use Rector\Config\RectorConfig;
+
+return RectorConfig::configure()
+	->withPaths([
+		__DIR__ . '/appinfo',
+		__DIR__ . '/lib',
+		__DIR__ . '/templates',
+		__DIR__ . '/tests/php',
+	])
+	->withSkipPath(__DIR__ . '/lib/Vendor')
+	->withPhpSets(php73: true)
+	->withSets([
+		NextcloudSets::NEXTCLOUD_27,
+	])
+	->withTypeCoverageLevel(0);

templates/index.php

@@ -6,5 +6,5 @@
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
-script('spreed', 'talk-main');
+\OCP\Util::addScript('spreed', 'talk-main');
 style('spreed', 'icons');

templates/recording.php

@@ -6,5 +6,5 @@
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
-script('spreed', 'talk-recording');
+\OCP\Util::addScript('spreed', 'talk-recording');
 style('spreed', 'icons');

vendor-bin/rector/composer.json

@@ -0,0 +1,6 @@
+{
+    "require-dev": {
+        "rector/rector": "^1.2.0",
+        "nextcloud/rector": "^0.2.1"
+    }
+}