Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] perf(ObjectStoreStorage): Improve (slow) move on same object bucket #48985

Merged
merged 2 commits into from
Oct 31, 2024

Commits on Oct 29, 2024

  1. perf(ObjectStoreStorage): Improve (slow) move on same object bucket

    This commit fixes the issue #47856. When you upload a file into a group folder and when you use a single S3 bucket as primary storage, the final move operation hangs for a long time. In the background, Nextcloud initiates a copy-delete sequence from the bucket into the bucket, with causes a lot unnecessary overhead. Nextcloud thinks that the file must be imported to another storage and does not recognize that everything is done on the same object bucket. In that case, the import step can be completely skipped, which saves time, network bandwidth and reduces the load on the object storage.
    
    The behavior improves a lot with #46013. However, there are still some put messages that are being sent to the object storage when you use an object storage as primary storage and upload files into a group folder.
    
    Co-authored-by: Kate <[email protected]>
    Signed-off-by: Christoph Fiehe <[email protected]>
    2 people authored and backportbot[bot] committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    dec5a5f View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. fix(tests): Fix most obvious errors in ObjectStore tests

    Some are still failing
    
    Signed-off-by: Côme Chilliet <[email protected]>
    come-nc authored and artonge committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    ab611a2 View commit details
    Browse the repository at this point in the history