Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Shipped apps should include the Nextcloud version in the cache buster #48650

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Oct 10, 2024

Summary

  1. The hash should also include the Nextcloud version if the app is shipped as every new Nextcloud update = new app version
  2. Cache the hash to prevent re-generation if the path is the same (e.g. the same app uses a lot of scripts / styles).

Checklist

@susnux susnux added bug 3. to review Waiting for reviews php Pull requests that update Php code feature: templates labels Oct 10, 2024
@susnux susnux added this to the Nextcloud 31 milestone Oct 10, 2024
Comment on lines +20 to +26
protected function setUp(): void {
parent::setUp();
}

protected function tearDown(): void {
parent::tearDown();
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
protected function setUp(): void {
parent::setUp();
}
protected function tearDown(): void {
parent::tearDown();
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug feature: templates php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Force reload required after upgrade 29 -> 30
2 participants