feat(http client): expose default request timeout constant to be used instead of magic number 30 #48639
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instead of magic number 30 Will be used to set default where we are able to override the default timeout. See #48418 Signed-off-by: Thomas Citharel <[email protected]>
tcitworld
added
3. to review
tcitworld
requested review from
kesselb,
pabzm,
a team,
Fenn-CS,
skjnldsv and
yemkareems
and removed request for
a team
4 tasks
|
The unconventional commits check is failing. Maybe a space in the scope is not valid? Could also use the new constant here: server/lib/private/Files/Storage/DAV.php Line 127 in d537050 |
skjnldsv
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will be used to set default where we are able to override the default timeout.
See #48418
Checklist