Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Return correct list of managers for a user #48538

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Oct 2, 2024

Summary

Fix #47642

Subadmins may not have access to certain users so we only return the uids for users that are accessible.

Checklist

@Pytal Pytal added this to the Nextcloud 31 milestone Oct 2, 2024
@Pytal Pytal requested review from artonge, come-nc and a team October 2, 2024 18:32
@Pytal Pytal self-assigned this Oct 2, 2024
@Pytal Pytal requested review from icewind1991 and removed request for a team October 2, 2024 18:32
lib/private/User/User.php Outdated Show resolved Hide resolved
come-nc

This comment was marked as resolved.

@Pytal Pytal force-pushed the fix/get-managers-as-subadmin branch from 2d200d1 to 2ecf322 Compare October 4, 2024 23:22
@Pytal Pytal requested a review from come-nc October 4, 2024 23:22
@Pytal Pytal force-pushed the fix/get-managers-as-subadmin branch from 2ecf322 to 06acad5 Compare October 4, 2024 23:28
Signed-off-by: Christopher Ng <[email protected]>
@Pytal Pytal force-pushed the fix/get-managers-as-subadmin branch from 06acad5 to f162b7a Compare October 8, 2024 23:30
@Pytal Pytal force-pushed the fix/get-managers-as-subadmin branch from f162b7a to 1dcdc87 Compare October 8, 2024 23:33
@Pytal Pytal enabled auto-merge October 8, 2024 23:34
@Pytal
Copy link
Member Author

Pytal commented Oct 8, 2024

/backport to stable30

@Pytal Pytal force-pushed the fix/get-managers-as-subadmin branch 3 times, most recently from c693156 to 2b6dbaf Compare October 9, 2024 00:09
Signed-off-by: Christopher Ng <[email protected]>
@Pytal Pytal force-pushed the fix/get-managers-as-subadmin branch from 2b6dbaf to 96035d2 Compare October 9, 2024 00:17
@Pytal Pytal merged commit d66e469 into master Oct 9, 2024
177 checks passed
@Pytal Pytal deleted the fix/get-managers-as-subadmin branch October 9, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: accounts -> error message as group manager when you are not allowed to fetch the line manager details
3 participants