feat: make systemtags public visible #48206
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
requested review from
susnux,
artonge,
a team,
ArtificialOwl and
sorbaugh
and removed request for
a team
susnux
reviewed
Sep 19, 2024
skjnldsv
commented
Sep 19, 2024
skjnldsv
force-pushed
the
feat/systemtags-public
branch
from
7244306
to
e3a0f90
Compare
skjnldsv
requested review from
susnux,
nickvergessen,
icewind1991 and
come-nc
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (!$event instanceof LoadAdditionalScriptsEvent) { | ||
| return; | ||
| } | ||
| Util::addInitScript(Application::APP_ID, 'init'); |
Check failure
Code scanning / Psalm
InvalidClass
come-nc
requested changes
Sep 19, 2024
skjnldsv
force-pushed
the
feat/systemtags-public
branch
3 times, most recently
from
ba84f93
to
33403e1
Compare
come-nc
approved these changes
Sep 19, 2024
skjnldsv
force-pushed
the
feat/systemtags-public
branch
from
663268a
to
9d535f6
Compare
apps/systemtags/lib/Listeners/BeforeSabrePubliclyLoadedListener.php
Outdated
Show resolved
Hide resolved
susnux
reviewed
Sep 20, 2024
susnux
reviewed
Sep 20, 2024
apps/systemtags/lib/Listeners/LoadAdditionalScriptsListener.php
Outdated
Show resolved
Hide resolved
susnux
reviewed
Sep 20, 2024
skjnldsv
force-pushed
the
feat/systemtags-public
branch
from
9d535f6
to
6973ce7
Compare
|
Done @susnux |
There are 2 flags: can assign, can see. Restricted is false, true. So would be okay to show from that perspective. But I can see how guests add a new angle to it. |
I'd prefer to avoid adding yet another config 😭 |
skjnldsv
added
2. developing
Signed-off-by: John Molakvoæ (skjnldsv) <[email protected]>
skjnldsv
force-pushed
the
feat/systemtags-public
branch
from
6973ce7
to
f70dbe7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #40364
Of course if the tag is made invisible in the settings, it will also apply.
I'm also thinking if it would make sense to NOT show restricted tags on public