Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(deps): Upgrade phpseclib to v3 #48183

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

feat(deps): Upgrade phpseclib to v3 #48183

wants to merge 2 commits into from
+140 −120

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Sep 18, 2024 •
edited
Loading

Summary

TODO

  • ...

Checklist

@susnux susnux requested a review from come-nc September 18, 2024 17:58
@susnux susnux mentioned this pull request Nov 5, 2024
Closed
@susnux
feat(deps): Upgrade phpseclib to v3
25d13a4 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
fixup: Fix files_external tests
9ca9c89 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
Copy link
Contributor Author

susnux commented Nov 5, 2024

Problem with this:
Checker::createSignatureData does create a different signature... No idea what is happening the parameters are the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc Awaiting requested review from come-nc

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@susnux