Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expand select and group by for calendar reminder backend #47399

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 commented Aug 21, 2024

Checklist

@miaulalala
Copy link
Contributor

apps/dav/tests/unit/CalDAV/Reminder/BackendTest.php:115 - I think you might need the id column after all but I haven't looked into it. LMK if you want to do a debugging call.

ChristophWurst

This comment was marked as outdated.

@ChristophWurst
Copy link
Member

/backport to stable30

@solracsf
Copy link
Member

There was 1 error:

1) OCA\DAV\Tests\unit\CalDAV\Reminder\BackendTest::testGetRemindersToProcess
Undefined array key "id"

/home/runner/actions-runner/_work/server/server/apps/dav/lib/CalDAV/Reminder/Backend.php:191
/home/runner/actions-runner/_work/server/server/apps/dav/lib/CalDAV/Reminder/Backend.php:57
/home/runner/actions-runner/_work/server/server/apps/dav/tests/unit/CalDAV/Reminder/BackendTest.php:115

@solracsf solracsf mentioned this pull request Sep 17, 2024
8 tasks
@miaulalala
Copy link
Contributor

This change fails for me with share notifications

@solracsf solracsf self-requested a review September 17, 2024 17:01
@solracsf solracsf added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Sep 17, 2024
@solracsf solracsf removed their request for review September 17, 2024 17:02
@hamza221 hamza221 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 18, 2024
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with ONLY_FULL_GROUP_BY on in mariadb. Master fails, this works

👍

@hamza221
Copy link
Contributor Author

Tested with ONLY_FULL_GROUP_BY on in mariadb. Master fails, this works

👍

Other tests are failing now, after rebase

@solracsf
Copy link
Member

I've previously submitted a, perhaps, less error-prone PR here (closed because this one was older) : #47996

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: DriverException during BackgroundJob
5 participants