-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sidebar): Show node owner in metadata subline #46691
Conversation
6aafa87
to
f0b68d7
Compare
Nice! Good idea using the user bubble component. I would suggest we include only the username in the user bubble, and to separate the different metadata we could use a middle dot
Also the user bubble component should be center aligned with the rest of the text :) |
f0b68d7
to
6a3886f
Compare
9c1c432
to
1a55a34
Compare
1a55a34
to
23fed46
Compare
23fed46
to
a512bfd
Compare
a512bfd
to
bcd9cd8
Compare
bcd9cd8
to
1a0b447
Compare
50600f2
to
c10edef
Compare
c10edef
to
5de2e05
Compare
cb22b2d
to
908165a
Compare
51d2ce5
to
0a5898f
Compare
0a5898f
to
4ee748f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to migrate the Sidebar to use proper Node data instead of legacy stuff, but until then this is probably the best way without patching legacy OC.Files.Client
Resolves: #46178 Signed-off-by: fenn-cs <[email protected]>
4ee748f
to
faa29a0
Compare
/compile |
/backport to stable30 |
Signed-off-by: nextcloud-command <[email protected]>
Summary
Show user bubble to indicate owner of file in sidebar overview (this should not change irrespective of share status)...
Resolves: #46178
Screenshots
TODO