Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable27] fix(ExternalSharing): Handle template shares from external sources #46279

Merged
merged 3 commits into from
Jul 12, 2024
Merged

[stable27] fix(ExternalSharing): Handle template shares from external sources #46279

merged 3 commits into from
Jul 12, 2024

Commits on Jul 12, 2024

  1. fix(ExternalSharing): Handle template share from external sources 

    The new sharing flow requires or implies that users should edit share before creating.
External sources should not created the share IF we would upon sharing details tab on first request.

Signed-off-by: fenn-cs <[email protected]>
    @nfebe
    nfebe committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    3b11104 View commit details
    Browse the repository at this point in the history

  2. refactor(SharingInput): Remove unused addShare 

    The new sharing flow since NC27 requires that users open the sharing details tab and

customize their share before creating it.

In #39472 the work of `addShare` was handed down to

`openSharingDetails` that opens the sharing details tab for the user to customize and manually

creat their share.

Signed-off-by: fenn-cs <[email protected]>
    @nfebe
    nfebe committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    ada08ed View commit details
    Browse the repository at this point in the history

  3. chore(assets): Recompile assets 

    Signed-off-by: nextcloud-command <[email protected]>
    @nextcloud-command @nfebe
    nextcloud-command authored and nfebe committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    8517c28 View commit details
    Browse the repository at this point in the history