Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(files): Update @nextcloud/files to v3.5.1 #45929

Merged
merged 5 commits into from
Jun 23, 2024
Merged

refactor(files): Update @nextcloud/files to v3.5.1 #45929

merged 5 commits into from
Jun 23, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jun 17, 2024 •
edited
Loading

Summary

Update @nextcloud/files and remove duplicated code.

Checklist

@susnux susnux added 3. to review Waiting for reviews dependencies ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Jun 17, 2024
@susnux susnux requested review from artonge, nfebe and Pytal June 17, 2024 15:08
@susnux susnux requested a review from skjnldsv as a code owner June 17, 2024 15:08
@solracsf solracsf added this to the Nextcloud 30 milestone Jun 18, 2024
@susnux susnux force-pushed the chore/update-nextcloud-files branch from 7c2c02a to 9490c49 Compare June 18, 2024 20:47
@susnux
Copy link
Contributor Author

susnux commented Jun 18, 2024

/compile

@susnux susnux enabled auto-merge June 18, 2024 20:47
@susnux susnux force-pushed the chore/update-nextcloud-files branch from a7bd407 to 2a250c9 Compare June 20, 2024 15:27
@susnux susnux changed the title refactor(files): Update @nextcloud/files to v3.5.0 refactor(files): Update @nextcloud/files to v3.5.1 Jun 20, 2024
@susnux susnux force-pushed the chore/update-nextcloud-files branch 4 times, most recently from 7e646c6 to a9d76bf Compare June 22, 2024 16:05
@susnux
refactor(files): Update @nextcloud/files to v3.5.0
a83f276 
* Removed now duplicated code

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
chore(deps): Update debounce to 2.1.0
81ad28f 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
fix(files_trashbin): Make files view registering an init script
dea5559 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
refactor: Use composable for currentView and views to make it rea…
3ed32ff 
…ctive when shared with other Vue apps

Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
chore: Compile assets
c8ec22f 
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux force-pushed the chore/update-nextcloud-files branch from a9d76bf to c8ec22f Compare June 23, 2024 14:56
@susnux susnux merged commit ff92ab1 into master Jun 23, 2024
165 checks passed
@susnux susnux deleted the chore/update-nextcloud-files branch June 23, 2024 15:19
@skjnldsv
Copy link
Member

skjnldsv commented Jul 3, 2024

Seeing all the changes made to the navigation reactivity, I guess that explains why 3.5.1 breaks stable28. This should have been a major if we had breaking changes @susnux
#46236

@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@artonge artonge artonge approved these changes

@nfebe nfebe Awaiting requested review from nfebe

@Pytal Pytal Awaiting requested review from Pytal

Assignees
No one assigned
Labels
3. to review Waiting for reviews dependencies ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
4 participants
@susnux @skjnldsv @artonge @solracsf