Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ShareApiClients): Maintain meaning of '' and null for share api cli… #45562

Merged
merged 1 commit into from
May 29, 2024

Conversation

nfebe
Copy link
Contributor

@nfebe nfebe commented May 29, 2024

Fix regression from : #44485

@nfebe nfebe added 3. to review Waiting for reviews feature: sharing labels May 29, 2024
@nfebe nfebe added this to the Nextcloud 27.1.10 milestone May 29, 2024
@nfebe nfebe requested review from artonge and ShGKme May 29, 2024 11:32
@nfebe nfebe self-assigned this May 29, 2024
@nfebe
Copy link
Contributor Author

nfebe commented May 29, 2024

/backport to stable27

@nfebe nfebe changed the title fix(ShareApiClients): Maintain meaning of and null for share api cli… fix(ShareApiClients): Maintain meaning of '' and null for share api cli… May 29, 2024
@nfebe nfebe force-pushed the fix-maintain-share-client-behaviour branch from ebbc6e6 to c8a90f0 Compare May 29, 2024 11:36
@ShGKme
Copy link
Contributor

ShGKme commented May 29, 2024

Should also be backported to 28 and 29 after #44485 is backported to 28 and 29

@nfebe
Copy link
Contributor Author

nfebe commented May 29, 2024

Should also be backported to 28 and 29 after #44485 is backported to 28 and 29

I would fix up? on 29 and 28? Since they are not merged yet? @ShGKme

@artonge
Copy link
Contributor

artonge commented May 29, 2024

/backport! to stable27

@nfebe nfebe merged commit a7a0557 into master May 29, 2024
155 checks passed
@nfebe nfebe deleted the fix-maintain-share-client-behaviour branch May 29, 2024 12:25
Copy link

backportbot bot commented May 29, 2024

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b backport/45562/stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick c8a90f04

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/45562/stable27

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/45562/stable27."}


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🏗️ In progress
Development

Successfully merging this pull request may close these issues.

3 participants