Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(IRegistrationContext): Add missing TaskProcessing methods #45345

Conversation

provokateurin
Copy link
Member

Summary

Follow up for #45094. The methods are present in the implementation but not in the interface, so the interface is not complete and also psalm complains about it.

Checklist

Copy link
Member

@marcelklehr marcelklehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange that the CI was green when I merged.

@provokateurin
Copy link
Member Author

Well the server CI is fine because the method is never called here. Just trying to call it from app_api it complains because the method is missing on the interface.

@provokateurin provokateurin merged commit ee8a97b into master May 16, 2024
155 checks passed
@provokateurin provokateurin deleted the fix/iregistrationcontext/add-missing-taskprocessing-methods branch May 16, 2024 10:59
@nickvergessen nickvergessen added the pending documentation This pull request needs an associated documentation update label Jul 18, 2024
@provokateurin provokateurin removed the pending documentation This pull request needs an associated documentation update label Jul 18, 2024
@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants