feat: Allow to enforce windows compatibility #45220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…files are enforced * Provide filename blacklist in public `\OCP\Util` * Use filename blacklist and forbidden characters also in `Filesystem::isFileBlacklisted` * Drop unused and deprecated `\OC_Util::isValidFileName` Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
…s unused Signed-off-by: Ferdinand Thiessen <[email protected]>
…acters` to the `oc_config` Signed-off-by: Ferdinand Thiessen <[email protected]>
It previously was, even if not documented, case insensitive. Signed-off-by: Ferdinand Thiessen <[email protected]>
This will: * Deny characters forbidden on Windows * Deny files with names which are reserved on Windows * Deny trailing dot or space * Deny files or folders which are not case-insensitive unique in a folder Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/allow-enforcing-windows-support
branch
from
bf78774
to
30a981b
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
susnux
force-pushed
the
fix/ensure-blacklist-is-honored
branch
3 times, most recently
from
7d074c7
to
458eae0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist