Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update shares on group removal #45217

Closed
wants to merge 1 commit into from
Closed

Update shares on group removal #45217

wants to merge 1 commit into from
+55 −0

Conversation

artonge
Copy link
Contributor

@artonge artonge commented May 7, 2024 •
edited by nickvergessen
Loading

No description provided.

@artonge artonge self-assigned this May 7, 2024
@artonge artonge requested a review from nickvergessen May 7, 2024 10:32
@artonge artonge added bug 3. to review Waiting for reviews feature: sharing php Pull requests that update Php code labels May 7, 2024
@artonge artonge added this to the Nextcloud 30 milestone May 7, 2024
@artonge
Copy link
Contributor Author

artonge commented May 7, 2024

/backport to stable29

@artonge
Copy link
Contributor Author

artonge commented May 7, 2024

/backport to stable28

@artonge
Copy link
Contributor Author

artonge commented May 7, 2024

/backport to stable27

@artonge
Copy link
Contributor Author

artonge commented May 7, 2024

/backport to stable26

@artonge artonge force-pushed the artonge/fix/listen_to_group_removal_for_share branch from c52730e to 1438871 Compare May 7, 2024 10:33
@artonge artonge marked this pull request as ready for review May 7, 2024 10:33
@artonge artonge force-pushed the artonge/fix/listen_to_group_removal_for_share branch from 1438871 to 77030c2 Compare May 7, 2024 10:39
susnux
susnux approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, we should have integration tests for this 😶

@artonge artonge force-pushed the artonge/fix/listen_to_group_removal_for_share branch from 77030c2 to 8b76821 Compare May 7, 2024 11:00
@artonge
Copy link
Contributor Author

artonge commented May 7, 2024

False positive, a listener was already added: https://github.com/nextcloud/server/blob/8b768210d2ac28b236617b20c19498085ddcf328/lib/private/Share20/UserRemovedListener.php

@artonge artonge closed this May 7, 2024
@skjnldsv skjnldsv removed this from the Nextcloud 30 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Altahrim Altahrim Altahrim approved these changes

@susnux susnux susnux approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

Assignees

@artonge artonge

Labels
3. to review Waiting for reviews backport-request bug feature: sharing php Pull requests that update Php code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@artonge @susnux @Altahrim @skjnldsv