Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: added customclient_fdroid key to the config.sample.php file #45193

Merged
merged 1 commit into from
Aug 6, 2024
Merged

docs: added customclient_fdroid key to the config.sample.php file #45193

merged 1 commit into from
Aug 6, 2024

Conversation

bahman026
Copy link
Contributor

@bahman026 bahman026 commented May 6, 2024 •
edited by fsamapoor
Loading

It appears that the customclient_fdroid key, responsible for storing the link to the Android app on the f-droid.org website, is absent from the config.sample.php file.

In this PR, I've included the customclient_fdroid config key in the config.sample.php file.

@bahman026 bahman026 marked this pull request as draft May 6, 2024 06:39
@bahman026 bahman026 closed this May 6, 2024
@bahman026 bahman026 reopened this May 6, 2024
@bahman026 bahman026 marked this pull request as ready for review May 6, 2024 06:48
@bahman026 bahman026 changed the title update config.sample.php file docs: added customclient_fdroid key to the config.sample.php file May 6, 2024
@fsamapoor fsamapoor self-requested a review May 6, 2024 07:02
fsamapoor
fsamapoor approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@fsamapoor fsamapoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's always great to have more first-time contributors on board!

@fsamapoor fsamapoor added the 3. to review Waiting for reviews label May 6, 2024
ChristophWurst
ChristophWurst approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 6, 2024
joshtrichards
joshtrichards approved these changes May 6, 2024
View reviewed changes
config/config.sample.php Outdated Show resolved Hide resolved
@ChristophWurst
Copy link
Member

Please squash your two commits into one

@bahman026 bahman026 force-pushed the update-config-sample-file branch 2 times, most recently from b7064e8 to 49093c2 Compare May 6, 2024 13:31
@bahman026
Copy link
Contributor Author

Please squash your two commits into one

Dear @ChristophWurst ,
I've implemented the changes. If there are no additional adjustments required, please proceed with merging this PR.
Thank you.

@ChristophWurst
Copy link
Member

ChristophWurst commented May 8, 2024 •
edited
Loading

The PR is set for merge: #45193 (comment)

Maintainers of this repo will merge the PR

@github-actions GitHub Actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@ChristophWurst ChristophWurst requested review from a team, ArtificialOwl, icewind1991 and yemkareems and removed request for a team May 21, 2024 06:05
@joshtrichards joshtrichards added this to the Nextcloud 30 milestone May 21, 2024
@joshtrichards
Copy link
Member

/backport to stable29

@joshtrichards
Copy link
Member

/backport to stable28

@joshtrichards
Copy link
Member

/backport to stable27

@joshtrichards joshtrichards force-pushed the update-config-sample-file branch 2 times, most recently from 0c5497c to 82e8bb5 Compare May 26, 2024 00:51
auto-merge was automatically disabled July 9, 2024 09:50

Head branch was pushed to by a user without write access

This was referenced Jul 30, 2024
Merged
Merged
@Altahrim Altahrim mentioned this pull request Aug 5, 2024
Merged
@AndyScherzinger AndyScherzinger merged commit 3419edd into nextcloud:master Aug 6, 2024
159 of 165 checks passed
@welcome Welcome
Copy link

welcome bot commented Aug 6, 2024

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

This was referenced Aug 6, 2024
Merged
Merged
Merged
@Altahrim Altahrim mentioned this pull request Aug 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsamapoor fsamapoor fsamapoor approved these changes

@joshtrichards joshtrichards joshtrichards approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems was automatically assigned from nextcloud/server-backend

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feedback-requested
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
5 participants
@bahman026 @ChristophWurst @joshtrichards @AndyScherzinger @fsamapoor