-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce app container border radius #44786
Conversation
marcoambrosini
commented
Apr 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will hard-coding introduce any new regressions for designs around the server? If there is a specific spot that we want to handle, should we not change the radius there instead? I am just curious for the reason, if its something that the designers have decided then I am fine with this :)
Hi @emoral435, this is part of a series of changes that the design team is making. Part of it is dialing back the border radii of some elements. So we want this change to be in all Nextcloud not just in a few places. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcoambrosini what @emoral435 is saying though is that setting it to 12px only here is a bit strange. Do we never use 12px as radius anywhere else? Shouldn’t it be using a variable, maybe even just 3*default-grid-baseline?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much nicer :) Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! :)
ddff451
to
f8ab2e6
Compare
687e3f1
to
4824908
Compare
Signed-off-by: Marco <[email protected]>
4824908
to
63e20cc
Compare
@nimishavijay @susnux @artonge do you have any further feedback? Otherwise let’s get this in while we are still early in the cycle. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good, if this was discussed by the design team then 👍