Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move retry logic to the QueryBuilder #44718

Closed
wants to merge 1 commit into from
Closed

Move retry logic to the QueryBuilder #44718

wants to merge 1 commit into from

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Apr 8, 2024 •
edited
Loading

Follow-up of #44504

@artonge artonge self-assigned this Apr 8, 2024
@artonge artonge added enhancement 2. developing Work in progress php Pull requests that update Php code labels Apr 8, 2024
@artonge artonge added this to the Nextcloud 30 milestone Apr 8, 2024
@artonge artonge force-pushed the artonge/feat/add_retry_support_to_query_builder branch 2 times, most recently from 560e934 to e9b7cb2 Compare April 8, 2024 12:07
@artonge artonge marked this pull request as ready for review April 8, 2024 12:08
@artonge artonge marked this pull request as draft April 8, 2024 12:09
@artonge artonge marked this pull request as ready for review April 8, 2024 12:12
@artonge artonge force-pushed the artonge/feat/add_retry_support_to_query_builder branch from e9b7cb2 to 9a650f6 Compare April 8, 2024 12:23
@artonge artonge force-pushed the artonge/feat/add_retry_support_to_query_builder branch from 9a650f6 to acc3428 Compare April 8, 2024 14:08
icewind1991
icewind1991 requested changes Apr 9, 2024
View reviewed changes
Copy link
Member

@icewind1991 icewind1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think retrying by default is a bad idea and can lead to unexpected behavior for developers

@artonge artonge force-pushed the artonge/feat/add_retry_support_to_query_builder branch from acc3428 to 9885ba2 Compare April 17, 2024 12:29
@artonge artonge force-pushed the artonge/feat/add_retry_support_to_query_builder branch from 9885ba2 to cd08495 Compare April 17, 2024 12:57
@artonge artonge closed this Apr 17, 2024
@skjnldsv skjnldsv removed this from the Nextcloud 30 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@icewind1991 icewind1991 icewind1991 requested changes

@come-nc come-nc come-nc approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@artonge artonge

Labels
2. developing Work in progress enhancement php Pull requests that update Php code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@artonge @nickvergessen @icewind1991 @juliusknorr @come-nc @skjnldsv