Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call davGetFavoritesReport after the registration of propfind properties #44714

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Call davGetFavoritesReport after the registration of propfind properties #44714

merged 1 commit into from
Apr 8, 2024

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Apr 8, 2024 •
edited
Loading

Before After
image Screenshot from 2024-04-08 10-58-00

@artonge artonge requested a review from skjnldsv as a code owner April 8, 2024 08:57
@artonge artonge force-pushed the artonge/fix/call_davGetFavoritesReport_after_init branch from baace87 to ba21d52 Compare April 8, 2024 08:58
@artonge artonge requested a review from susnux April 8, 2024 08:58
@artonge artonge self-assigned this Apr 8, 2024
@artonge artonge modified the milestones: Nextcloud 29, Nextcloud 30 Apr 8, 2024
@artonge
Copy link
Contributor Author

artonge commented Apr 8, 2024

/backport to stable29

@artonge
Copy link
Contributor Author

artonge commented Apr 8, 2024

/backport to stable28

@artonge artonge force-pushed the artonge/fix/call_davGetFavoritesReport_after_init branch 2 times, most recently from 28da323 to 44026d3 Compare April 8, 2024 11:03
susnux
susnux approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really important and nice catch!

@susnux susnux requested a review from Pytal April 8, 2024 11:26
@artonge artonge force-pushed the artonge/fix/call_davGetFavoritesReport_after_init branch from 44026d3 to cde41b5 Compare April 8, 2024 11:30
@artonge artonge force-pushed the artonge/fix/call_davGetFavoritesReport_after_init branch from cde41b5 to c4534e8 Compare April 8, 2024 11:38
@artonge artonge enabled auto-merge April 8, 2024 13:21
@artonge artonge merged commit 659307e into master Apr 8, 2024
104 checks passed
@artonge artonge deleted the artonge/fix/call_davGetFavoritesReport_after_init branch April 8, 2024 21:43
This was referenced Apr 8, 2024
Merged
Merged
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@susnux susnux susnux approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner

Assignees

@artonge artonge

Labels
3. to review Waiting for reviews bug feature: files javascript
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
3 participants
@artonge @susnux @Pytal