enh: Send empty expireDate when not expireDate set #44291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfebe
added
enhancement
3. to review
nfebe
commented
Mar 18, 2024
There was a problem hiding this comment.
Looks like the backend still ignores the empty value and uses the default. So, converted to draft.
Context : #44219 (comment)
cc: @Altahrim
skjnldsv
added
2. developing
nfebe
force-pushed
the
44219-send-share-expiry-val
branch
3 times, most recently
from
59bfdaa
to
2c2fe01
Compare
|
Moved the back-end wip-commit here : #44485, so this is ready for review/merge |
nfebe
force-pushed
the
44219-send-share-expiry-val
branch
from
2c2fe01
to
f340f0a
Compare
When creating a new share, if the user unchecks "Set expiry date" no `expireDate` is sent to the server. However, the server then assumes the default configured, hence better to send an empty value. Signed-off-by: fenn-cs <[email protected]>
nfebe
force-pushed
the
44219-send-share-expiry-val
branch
from
f340f0a
to
d2b0848
Compare
Altahrim
approved these changes
Mar 26, 2024
|
/compile / |
Signed-off-by: nextcloud-command <[email protected]>
|
/backport to stable28 |
|
/backport to stable27 |
2 tasks
2 tasks
Merged
|
This bug still exists in NC 27.1.9 |
|
Should be fixed with #44485 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a new share, if the user unchecks "Set expiry date" no
expireDateis sent to the server.However, the server then assumes the default configured, hence better to send an empty value.
Resolves : #44219