-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(styles): Adjust heading styles #43640
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Settings are a bit inconsistent because those rendered with Vue are using NcSetttingsSection and it has font-size: 20px for .settings-section__name.
There are also a few headings that should be demoted to simple text, like here for external storage:
Not sure if we want to do this here or in a follow-up. Settings probably need a bit of a design review after this change.
I would do it in a follow-up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Screenshots look great :)
If we agree on this changes here we should adjust nextcloud-vue styles accordingly. |
@jancborchardt do we want to use this styles or adjust them because of nextcloud/text#5515 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's showtime
Let's add this to the app dev upgrade docs as "breaking" frontend change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @susnux but maybe as a follow-up it would make sense to adjust it to the sizes in https://github.com/nextcloud/text/pull/5594/files ? Maybe from h1 → h2 though because h2 is the first visible one (h1 is always the logo).
Make headings look like real headings and not just ordinary text. The stylings are copied from the text app where a design review was done on them. Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
243ea8e
to
ff11956
Compare
Sizes adjusted ✅
Done ✅ |
Summary
Make headings look like real headings and not just ordinary text.
The styles are copied from the text-app where a design review was done on them.
Screenshots
Code used:
Checklist