Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(caldav): linkify location in scheduling mails #39753

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Aug 8, 2023

Summary

Invitation

grafik

Event is updated

grafik

TODO

  • Probably tests

Checklist

@st3iny st3iny added enhancement 2. developing Work in progress feature: caldav Related to CalDAV internals labels Aug 8, 2023
@st3iny st3iny self-assigned this Aug 8, 2023
@st3iny
Copy link
Member Author

st3iny commented Aug 8, 2023

I tried to inject evil code into the location field but it was sanitized properly. The general email html sanitization seems to take care of this.

@st3iny st3iny force-pushed the feat/caldav/linkify-location-in-email branch from 58f0657 to 5671393 Compare August 8, 2023 14:17
@st3iny st3iny added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 8, 2023
@st3iny st3iny marked this pull request as ready for review August 8, 2023 14:18
@ChristophWurst
Copy link
Member

/backport to stable27

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@st3iny st3iny added this to the Nextcloud 28 milestone Aug 9, 2023
@st3iny st3iny force-pushed the feat/caldav/linkify-location-in-email branch from ed64f30 to 2ac24d5 Compare August 9, 2023 08:50
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 9, 2023
@ChristophWurst ChristophWurst merged commit df304bd into master Aug 9, 2023
34 of 36 checks passed
@ChristophWurst ChristophWurst deleted the feat/caldav/linkify-location-in-email branch August 9, 2023 16:11
@ChristophWurst
Copy link
Member

/backport to stable27

@ChristophWurst
Copy link
Member

/backport to stable27

@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

1 similar comment
@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@ChristophWurst
Copy link
Member

/backport to stable27

@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

1 similar comment
@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@ChristophWurst
Copy link
Member

/backport to stable27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: caldav Related to CalDAV internals
Projects
Development

Successfully merging this pull request may close these issues.

Improve handling of links for online events
3 participants