Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: File reminders backend #39651

Merged
merged 38 commits into from
Aug 3, 2023
Merged

feat: File reminders backend #39651

merged 38 commits into from
Aug 3, 2023

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Aug 1, 2023 •
edited
Loading

Summary

  • HTTP API
  • Notifier
  • Scheduled notifications
  • Clean up job

Checklist

@Pytal Pytal added this to the Nextcloud 27.1.0 milestone Aug 1, 2023
@Pytal Pytal self-assigned this Aug 1, 2023
@Pytal Pytal force-pushed the feat/files-reminders branch 2 times, most recently from d4d2332 to eeef52b Compare August 1, 2023 22:42
@Pytal Pytal modified the milestones: Nextcloud 27.1.0, Nextcloud 28 Aug 3, 2023
@Pytal Pytal mentioned this pull request Aug 3, 2023
Merged
10 tasks
come-nc
come-nc approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess another listener for if the user is deleted is needed as well, good otherwise.

susnux
susnux approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

apps/files_reminders/lib/Listener/NodeDeletedListener.php Show resolved Hide resolved
Pytal added 13 commits August 3, 2023 15:30
@Pytal
feat: init files_reminders migration
e16001b 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
feat(files_reminders): add Application
59a2ef4 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
feat(files_reminders): add info xml
b75fac3 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
feat(files_reminders): add background jobs
a3ac1b8 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
feat(files_reminders): add service and notifier
ea5e128 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
feat(files_reminders): add list command
c8a32a7 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
enh: use datetime
163b059 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
enh: add created at
4fabd77 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
enh: implement JsonSerializable
774e3e6 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
feat(files_reminders): add api controller
a7892fb 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
fix: add composer autoload
cfbac9b 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
enh: add to shipped
beb8a27 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
enh: rename to due date
fa77564 
Signed-off-by: Christopher Ng <[email protected]>
Pytal added 19 commits August 3, 2023 15:30
@Pytal
enh: return created status code
bdf0741 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
enh: comment interval
b04d1a7 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
enh: serialize path
db7f5a2 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
enh: does not exist return null
9bd7ddd 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
fix: return ocs data
3ade06c 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
fix: remove throwable handling
7daf11f 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
fix: construct background jobs
7617519 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
enh: handle node deleted
f865c3a 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
fix: exit on reminder not found
9e8354e 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
fix: catch NodeNotFoundException in notifier
c4b7056 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
enh: highlight filename
7beef65 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
fix: remove unnecessary parsed subject
7381c80 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
fix: return null if table exists
d619166 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
enh: add codeowner
113d061 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
enh: add json output to command
e320166 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
fix: ignore non-existing
2c4b562 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
fix(ci): add to enabled apps
af98c70 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
fix: set endpoint description
5a11535 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal
enh: handle user deleted
a806bd0 
Signed-off-by: Christopher Ng <[email protected]>
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 3, 2023
@Pytal Pytal merged commit 777f8c9 into master Aug 3, 2023
37 checks passed
@Pytal Pytal deleted the feat/files-reminders branch August 3, 2023 23:38
@Pytal Pytal mentioned this pull request Aug 3, 2023
Closed
3 tasks
@Pytal
Copy link
Member Author

Pytal commented Aug 8, 2023

/backport to stable27

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Aug 8, 2023
Merged
@nickvergessen nickvergessen mentioned this pull request Aug 18, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@susnux susnux susnux approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: files
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
3 participants
@Pytal @susnux @come-nc