-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AI admin settings #39567
AI admin settings #39567
Conversation
switch($key) { | ||
case 'ai.textprocessing_provider_preferences': | ||
// fill $value with $defaultValue values | ||
$value = array_merge($defaultValue, $value); |
Check notice
Code scanning / Psalm
PossiblyInvalidArgument Note
$value = array_merge($defaultValue, $value); | ||
break; | ||
case 'ai.translation_provider_preferences': | ||
$value += array_diff($defaultValue, $value); // Add entries from $defaultValue that are not in $value to the end of $value |
Check notice
Code scanning / Psalm
PossiblyInvalidArgument Note
Nice! But keep in mind vuedragable is not accessible, so there is no way to reorder by using the keyboard, this needs to be done by the user of the component itself. |
8cf0663
to
841a2fb
Compare
@susnux How would you go about adding a11y here? |
For Forms I suggested this one: nextcloud/forms#1532 So basically either implement key event listeners (arrow up / down) or add additional buttons for ordering |
/compile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, tested with a FreePrompt, a Summarize and an Outline TP provider.
The fallback works just fine if a provider fails.
Small string changes requested but all the rest LGTM.
I'm also wondering if all the unrelated stuff belongs here but since these are nice fixes, why not letting them in this.
About accessibility, there could be 2 buttons to move items up and down.
Already added :) (see screenshot above) |
0d71d57
to
dd6e92f
Compare
81d3c4d
to
d2e75af
Compare
/compile |
@Pytal Thanks for the review. Your changes have been implemented. |
1537edf
to
474de78
Compare
Signed-off-by: Marcel Klehr <[email protected]>
…r precedence Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Co-authored-by: Julien Veyssier <[email protected]> Signed-off-by: Marcel Klehr <[email protected]>
Co-authored-by: Julien Veyssier <[email protected]> Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
5f262ca
to
b13ca86
Compare
Cypress failure is related with user settings. |
Fix: #39684 |
Summary
Adds an admin settings section for AI settings, allowing admins to specify the precedence of machine translation providers, set the speech-to-text provider to use and select which text processing provider to use for which task.
Checklist