Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utility): De- deprecate getDateTime and getTime as now() only returns DateTimeImmutable #39511

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

miaulalala
Copy link
Contributor

@miaulalala miaulalala commented Jul 20, 2023

This will mean lots of code like
$dateTime = (new DateTime())->setTimestamp(ITimeFactory::now()->getTimestamp())
if a regular DateTime object is needed

Checklist

@miaulalala miaulalala added the 3. to review Waiting for reviews label Jul 20, 2023
@miaulalala miaulalala requested review from nickvergessen and a team July 20, 2023 15:01
@miaulalala miaulalala self-assigned this Jul 20, 2023
@miaulalala miaulalala requested review from ArtificialOwl, icewind1991 and nfebe and removed request for a team July 20, 2023 15:02
@miaulalala
Copy link
Contributor Author

/backport to stable27

@miaulalala
Copy link
Contributor Author

/backport to stable26

@miaulalala
Copy link
Contributor Author

miaulalala commented Jul 26, 2023

Failing test is Scenario: log in with invalid user once fixed by admin - unrelated.

@miaulalala miaulalala force-pushed the fix/reverse-getDateTime-deprecation branch 2 times, most recently from ea72ac1 to eaec1d7 Compare August 18, 2023 06:16
@miaulalala miaulalala changed the title fix(utility): De- deprecate getDateTime as now() only returns DateTimeImmutable fix(utility): De- deprecate getDateTime and getTime as now() only returns DateTimeImmutable Aug 18, 2023
@miaulalala miaulalala force-pushed the fix/reverse-getDateTime-deprecation branch from eaec1d7 to 1989abc Compare August 25, 2023 06:19
…le objects

This will mean lots of code like
```$dateTime = (new DateTime())->setTimestamp(ITimeFactory::now()->getTimestamp()```
if a regular DateTime object is needed

Signed-off-by: Anna Larch <[email protected]>
@miaulalala miaulalala force-pushed the fix/reverse-getDateTime-deprecation branch from 1989abc to 66c1aa4 Compare August 25, 2023 06:56
@nickvergessen nickvergessen merged commit 85ff144 into master Aug 25, 2023
37 checks passed
@nickvergessen nickvergessen deleted the fix/reverse-getDateTime-deprecation branch August 25, 2023 08:02
@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

4 participants