-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(utility): De- deprecate getDateTime and getTime as now() only returns DateTimeImmutable #39511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miaulalala
requested review from
ArtificialOwl,
icewind1991 and
nfebe
and removed request for
a team
July 20, 2023 15:02
/backport to stable27 |
/backport to stable26 |
nickvergessen
approved these changes
Jul 20, 2023
Failing test is |
miaulalala
force-pushed
the
fix/reverse-getDateTime-deprecation
branch
2 times, most recently
from
August 18, 2023 06:16
ea72ac1
to
eaec1d7
Compare
miaulalala
changed the title
fix(utility): De- deprecate getDateTime as now() only returns DateTimeImmutable
fix(utility): De- deprecate getDateTime and getTime as now() only returns DateTimeImmutable
Aug 18, 2023
miaulalala
force-pushed
the
fix/reverse-getDateTime-deprecation
branch
from
August 25, 2023 06:19
eaec1d7
to
1989abc
Compare
…le objects This will mean lots of code like ```$dateTime = (new DateTime())->setTimestamp(ITimeFactory::now()->getTimestamp()``` if a regular DateTime object is needed Signed-off-by: Anna Larch <[email protected]>
miaulalala
force-pushed
the
fix/reverse-getDateTime-deprecation
branch
from
August 25, 2023 06:56
1989abc
to
66c1aa4
Compare
Altahrim
approved these changes
Aug 25, 2023
bigcat88
approved these changes
Aug 25, 2023
The backport to stable26 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable26
git pull origin stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will mean lots of code like
$dateTime = (new DateTime())->setTimestamp(ITimeFactory::now()->getTimestamp())
if a regular DateTime object is needed
Checklist