Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(db): Ensure that index names are unique across the database #39506

Merged
merged 2 commits into from
Jul 24, 2023
Merged

feat(db): Ensure that index names are unique across the database #39506

merged 2 commits into from
Jul 24, 2023

Conversation

nickvergessen
Copy link
Member

Error when enabling Talk after Text was enabled (before nextcloud/text#4553 )

Index name "ts_session" for table "oc_talk_sessions" collides with the constraint on table "oc_text_steps".

Checklist

@nickvergessen nickvergessen added this to the Nextcloud 28 milestone Jul 20, 2023
@nickvergessen nickvergessen self-assigned this Jul 20, 2023
juliusknorr
juliusknorr approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of that 💙

@nickvergessen nickvergessen merged commit 7548e62 into master Jul 24, 2023
36 checks passed
@nickvergessen nickvergessen deleted the techdebt/39488/ensure-index-name-uniqueness branch July 24, 2023 12:44
@joshtrichards joshtrichards mentioned this pull request Dec 13, 2023
Closed
8 tasks
@kesselb kesselb mentioned this pull request Jan 13, 2024
Closed
8 tasks
This was referenced Feb 4, 2024
Closed
Merged
joshtrichards added a commit to nextcloud/documentation that referenced this pull request Feb 17, 2024
@joshtrichards
docs(dev): Mention new uniqueness check for index names
04de7b5 
Follow-on to nextcloud/server#39506 & nextcloud/server#43357

Signed-off-by: Josh <[email protected]>
@joshtrichards joshtrichards mentioned this pull request Feb 17, 2024
Merged
backportbot bot pushed a commit to nextcloud/documentation that referenced this pull request Mar 7, 2024
@joshtrichards @backportbot
docs(dev): Mention new uniqueness check for index names
6fe96d8 
Follow-on to nextcloud/server#39506 & nextcloud/server#43357

Signed-off-by: Josh <[email protected]>
acataluddi pushed a commit to acataluddi/nextcloud-documentation that referenced this pull request Apr 28, 2024
@joshtrichards @acataluddi
docs(dev): Mention new uniqueness check for index names
d29a4eb 
Follow-on to nextcloud/server#39506 & nextcloud/server#43357

Signed-off-by: Josh <[email protected]>
Signed-off-by: Adriano Cataluddi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@kesselb kesselb Awaiting requested review from kesselb

Assignees

@nickvergessen nickvergessen

Labels
3. to review Waiting for reviews technical debt
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

Add a check to the Schema to ensure indexes are unique
3 participants
@nickvergessen @ChristophWurst @juliusknorr