chore(3rdparty): update punic to 3.8.1

[kesselb]

Summary

Beware! The Punic and CLDR updates brought some changes to the generated date and time formats. I don't think that's a problem unless we parse those strings somewhere else.

Update punic to 3.8.1.

Major library update. The directory structure changed and thus almost everything is changed.

We are using the Calendar component in lib/private/L10N/L10N.php.

If we make php-intl a required extension, we could use IntlCalendar and drop punic as a dependency.

TODO

• Testing
• CI
• Merge chore: update punic to 3.8.1 3rdparty#1484
• Rebase

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[kesselb]

There were 15 failures:

1) Test\DateTimeFormatterTest::testFormatDateTime with data set #0 (1350129205, null, 'October 13, 2012 at 11:53:25 AM GMT+0')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'October 13, 2012 at 11:53:25 AM GMT+0'
+'October 13, 2012, 11:53:25 AM UTC'

/drone/src/tests/lib/DateTimeFormatterTest.php:175

2) Test\DateTimeFormatterTest::testFormatDateTime with data set #1 (1350129205, DateTimeZone Object (...), 'October 13, 2012 at 1:53:25 PM GMT+2')
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'October 13, 2012 at 1:53:25 PM GMT+2'
+'October 13, 2012, 1:53:25 PM GMT+2'

/drone/src/tests/lib/DateTimeFormatterTest.php:175

3) Test\L10N\L10nTest::testNumericStringLocalization with data set #0 ('February 13, 2009 at 11:31:30 PM GMT+0', 'en', 'en_US', 'datetime', '1234567890')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'February 13, 2009 at 11:31:30 PM GMT+0'
+'February 13, 2009, 11:31:30 PM UTC'

/drone/src/tests/lib/L10N/L10nTest.php:159

4) Test\L10N\L10nTest::testNumericStringLocalization with data set #1 ('13. Februar 2009 um 23:31:30 GMT+0', 'de', 'de_DE', 'datetime', '1234567890')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'13. Februar 2009 um 23:31:30 GMT+0'
+'13. Februar 2009, 23:31:30 UTC'

/drone/src/tests/lib/L10N/L10nTest.php:159

5) Test\L10N\L10nTest::testNumericStringLocalization with data set #4 ('11:31:30 PM GMT+0', 'en', 'en_US', 'time', '1234567890')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'11:31:30 PM GMT+0'
+'11:31:30 PM UTC'

/drone/src/tests/lib/L10N/L10nTest.php:159

6) Test\L10N\L10nTest::testNumericStringLocalization with data set #5 ('23:31:30 GMT+0', 'de', 'de_DE', 'time', '1234567890')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'23:31:30 GMT+0'
+'23:31:30 UTC'

/drone/src/tests/lib/L10N/L10nTest.php:159

7) Test\L10N\L10nTest::testNumericStringLocalization with data set #6 ('February 13, 2009 at 11:31:30 PM GMT+0', 'en', 'en_US', 'datetime', 1234567890)
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'February 13, 2009 at 11:31:30 PM GMT+0'
+'February 13, 2009, 11:31:30 PM UTC'

/drone/src/tests/lib/L10N/L10nTest.php:159

8) Test\L10N\L10nTest::testNumericStringLocalization with data set #7 ('13. Februar 2009 um 23:31:30 GMT+0', 'de', 'de_DE', 'datetime', 1234567890)
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'13. Februar 2009 um 23:31:30 GMT+0'
+'13. Februar 2009, 23:31:30 UTC'

/drone/src/tests/lib/L10N/L10nTest.php:159

9) Test\L10N\L10nTest::testNumericStringLocalization with data set #10 ('11:31:30 PM GMT+0', 'en', 'en_US', 'time', 1234567890)
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'11:31:30 PM GMT+0'
+'11:31:30 PM UTC'

/drone/src/tests/lib/L10N/L10nTest.php:159

10) Test\L10N\L10nTest::testNumericStringLocalization with data set #11 ('23:31:30 GMT+0', 'de', 'de_DE', 'time', 1234567890)
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'23:31:30 GMT+0'
+'23:31:30 UTC'

/drone/src/tests/lib/L10N/L10nTest.php:159

11) Test\L10N\L10nTest::testNumericStringLocalization with data set #12 ('February 13, 2009 at 11:31:30 PM GMT+0', 'en', 'en_US', 'datetime', DateTime Object (...))
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'February 13, 2009 at 11:31:30 PM GMT+0'
+'February 13, 2009, 11:31:30 PM GMT+0'

/drone/src/tests/lib/L10N/L10nTest.php:159

12) Test\L10N\L10nTest::testNumericStringLocalization with data set #13 ('13. Februar 2009 um 23:31:30 GMT+0', 'de', 'de_DE', 'datetime', DateTime Object (...))
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'13. Februar 2009 um 23:31:30 GMT+0'
+'13. Februar 2009, 23:31:30 GMT+0'

/drone/src/tests/lib/L10N/L10nTest.php:159

13) Test\L10N\L10nTest::testNumericStringLocalization with data set #16 ('11:31:30 PM GMT+0', 'en', 'en_US', 'time', DateTime Object (...))
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'11:31:30 PM GMT+0'
+'11:31:30 PM GMT+0'

/drone/src/tests/lib/L10N/L10nTest.php:159

14) Test\L10N\L10nTest::testNumericStringLocalization with data set #18 ('13 February 2009 at 23:31:30 GMT+0', 'en_GB', 'en_GB', 'datetime', DateTime Object (...))
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'13 February 2009 at 23:31:30 GMT+0'
+'13 February 2009, 23:31:30 GMT+0'

/drone/src/tests/lib/L10N/L10nTest.php:159

15) Test\L10N\L10nTest::testNumericStringLocalization with data set #21 ('13 February 2009 at 23:31:30 GMT+0', 'en-GB', 'en_GB', 'datetime', DateTime Object (...))
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'13 February 2009 at 23:31:30 GMT+0'
+'13 February 2009, 23:31:30 GMT+0'

/drone/src/tests/lib/L10N/L10nTest.php:159

[kesselb]

-'11:31:30 PM GMT+0'
+'11:31:30 PM UTC'

punic/punic#140

-'11:31:30 PM GMT+0'
+'11:31:30 PM GMT+0'

CLDR 42 added a NARROW NO-BREAK SPACE for some time and date definitions. The idea is to prevent a break between a time definition.

'February 13, 2009 at 11:31:30 PM UTC'
'February 13, 2009, 11:31:30 PM UTC'

Also from upstream punic/cldr: https://github.com/unicode-org/cldr/pull/2367/files

[mejo-]

Drone samba failure seems unrelated, test adjustments seem sensible 😊