Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert isset ternary to null coalescing operator #39225

Merged

Conversation

shdehnavi
Copy link
Contributor

Summary

This PR aims to enhance code readability and simplify ternary operations in the codebase. It replaces all instances of isset ternary operations with the more concise and expressive null coalescing operator in /apps/ namespace. The conversion eliminates unnecessary redundancy and improves maintainability.

Checklist

@solracsf solracsf added this to the Nextcloud 28 milestone Jul 9, 2023
@solracsf solracsf added 3. to review Waiting for reviews technical debt labels Jul 9, 2023
@miaulalala
Copy link
Contributor

/rebase

@fsamapoor
Copy link
Member

@shdehnavi Could you please resolve the conflicts and rebase?

@shdehnavi shdehnavi force-pushed the null_coalescing_conversion_apps branch from 928c336 to d64bbc8 Compare September 28, 2023 08:50
@shdehnavi
Copy link
Contributor Author

@shdehnavi Could you please resolve the conflicts and rebase?

Thank you, Resolved and Rebased.

@ChristophWurst ChristophWurst merged commit 1a1514e into nextcloud:master Sep 28, 2023
45 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants