Migrate parts of files app away from depecrated Ilogger #39218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfebe
force-pushed
the
32127-migrate-parts-of-files-from-ilogger
branch
from
3dffda9
to
d466c95
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
nfebe
force-pushed
the
32127-migrate-parts-of-files-from-ilogger
branch
4 times, most recently
from
08c9b8a
to
1e8e58f
Compare
nfebe
force-pushed
the
32127-migrate-parts-of-files-from-ilogger
branch
from
1e8e58f
to
9351b1c
Compare
come-nc
reviewed
Jul 17, 2023
nfebe
force-pushed
the
32127-migrate-parts-of-files-from-ilogger
branch
2 times, most recently
from
6b81a3f
to
0d807fa
Compare
nfebe
force-pushed
the
32127-migrate-parts-of-files-from-ilogger
branch
2 times, most recently
from
cbcbc45
to
a00c390
Compare
nfebe
force-pushed
the
32127-migrate-parts-of-files-from-ilogger
branch
3 times, most recently
from
28d4e65
to
ec4067e
Compare
come-nc
approved these changes
Jul 27, 2023
nfebe
force-pushed
the
32127-migrate-parts-of-files-from-ilogger
branch
from
3d5df9f
to
7b7b720
Compare
Altahrim
approved these changes
Aug 3, 2023
nfebe
force-pushed
the
32127-migrate-parts-of-files-from-ilogger
branch
from
7b7b720
to
8b6c38b
Compare
Altahrim
approved these changes
Aug 7, 2023
This comment was marked as resolved.
This comment was marked as resolved.
|
@fenn-cs You need to update the tests to adapt them to the changes you made to the background job constructor. |
nfebe
force-pushed
the
32127-migrate-parts-of-files-from-ilogger
branch
2 times, most recently
from
1bf76b6
to
3ad75c8
Compare
nfebe
force-pushed
the
32127-migrate-parts-of-files-from-ilogger
branch
from
3ad75c8
to
cb55dee
Compare
|
@solracsf fixed related failures, please can you give this one more review so I can manually merge this? |
- Migrate some backgrounds jobs, `TransferOwnership` & `DeleteOrphanedItems` - Migrate `DirectEditingController` Signed-off-by: fenn-cs <[email protected]>
nfebe
force-pushed
the
32127-migrate-parts-of-files-from-ilogger
branch
from
cb55dee
to
dc8d25c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TransferOwnership&DeleteOrphanedItemsDirectEditingControllerResolves : #32127