Skip to content

Commit

Permalink
Merge pull request #40294 from nextcloud/fix/37087/new-comment-descri…
Browse files Browse the repository at this point in the history
…ption

fix(comments): move new comment instructions placeholder to description
  • Loading branch information
ShGKme authored Oct 7, 2023
2 parents 5979651 + 0ce5a34 commit f2572eb
Show file tree
Hide file tree
Showing 4 changed files with 45 additions and 29 deletions.
61 changes: 37 additions & 24 deletions apps/comments/src/components/Comment.vue
Original file line number Diff line number Diff line change
Expand Up @@ -68,26 +68,33 @@
</div>

<!-- Message editor -->
<div v-if="editor || editing" class="comment__editor ">
<NcRichContenteditable ref="editor"
:auto-complete="autoComplete"
:contenteditable="!loading"
:value="localMessage"
:user-data="userData"
@update:value="updateLocalMessage"
@submit="onSubmit" />
<NcButton class="comment__submit"
type="tertiary-no-background"
native-type="submit"
:aria-label="t('comments', 'Post comment')"
:disabled="isEmptyMessage"
@click="onSubmit">
<template #icon>
<span v-if="loading" class="icon-loading-small" />
<ArrowRight v-else :size="20" />
</template>
</NcButton>
</div>
<form v-if="editor || editing" class="comment__editor" @submit.prevent>
<div class="comment__editor-group">
<NcRichContenteditable ref="editor"
:auto-complete="autoComplete"
:contenteditable="!loading"
:value="localMessage"
:user-data="userData"
aria-describedby="tab-comments__editor-description"
@update:value="updateLocalMessage"
@submit="onSubmit" />
<div class="comment__submit">
<NcButton type="tertiary-no-background"
native-type="submit"
:aria-label="t('comments', 'Post comment')"
:disabled="isEmptyMessage"
@click="onSubmit">
<template #icon>
<span v-if="loading" class="icon-loading-small" />
<ArrowRight v-else :size="20" />
</template>
</NcButton>
</div>
</div>
<div id="tab-comments__editor-description" class="comment__editor-description">
{{ t('comments', '"@" for mentions, ":" for emoji, "/" for smart picker') }}
</div>
</form>

<!-- Message content -->
<!-- The html is escaped and sanitized before rendering -->
Expand Down Expand Up @@ -273,7 +280,6 @@ $comment-padding: 10px;
.comment {
display: flex;
gap: 16px;
position: relative;
padding: 5px $comment-padding;
&__side {
Expand Down Expand Up @@ -313,12 +319,19 @@ $comment-padding: 10px;
color: var(--color-text-maxcontrast);
}
&__editor-group {
position: relative;
}
&__editor-description {
color: var(--color-text-maxcontrast);
padding-block: var(--default-grid-baseline);
}
&__submit {
position: absolute !important;
right: 0;
bottom: 0;
// Align with input border
margin: 1px;
right: 0;
}
&__message {
Expand Down
7 changes: 5 additions & 2 deletions apps/comments/src/views/Comments.vue
Original file line number Diff line number Diff line change
Expand Up @@ -315,10 +315,13 @@ export default {

<style lang="scss" scoped>
.comments {
// Do not add emptycontent top margin
min-height: 100%;
display: flex;
flex-direction: column;
&__empty,
&__error {
margin-top: 0 !important;
flex: 1 0;
}
&__retry {
Expand Down
4 changes: 2 additions & 2 deletions dist/comments-comments-app.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/comments-comments-app.js.map

Large diffs are not rendered by default.

0 comments on commit f2572eb

Please sign in to comment.