Merge pull request #45058 from nextcloud/perf/db/sort-before-chunking

perf(db): Sort data for IN before chunking
nextcloud · May 7, 2024 · 6258823 · 6258823
2 parents 0af06f6 + f3d6309
commit 6258823
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/lib/private/Files/Cache/Cache.php b/lib/private/Files/Cache/Cache.php
@@ -620,6 +620,9 @@ private function removeChildren(ICacheEntry $entry) {
 		$query->delete('filecache')
 			->whereParentInParameter('parentIds');
 
+		// Sorting before chunking allows the db to find the entries close to each
+		// other in the index
+		sort($parentIds, SORT_NUMERIC);
 		foreach (array_chunk($parentIds, 1000) as $parentIdChunk) {
 			$query->setParameter('parentIds', $parentIdChunk, IQueryBuilder::PARAM_INT_ARRAY);
 			$query->execute();