Move template settings to vue component #4125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elzody
force-pushed
the
fix/templates-admin-settings
branch
2 times, most recently
from
904c3c4
to
9391b63
Compare
elzody
added
enhancement
elzody
force-pushed
the
fix/templates-admin-settings
branch
2 times, most recently
from
36bb8be
to
9bb70f5
Compare
elzody
changed the title
juliusknorr
reviewed
Nov 5, 2024
Signed-off-by: Elizabeth Danzberger <[email protected]>
juliusknorr
force-pushed
the
fix/templates-admin-settings
branch
from
9bb70f5
to
fc11c12
Compare
juliusknorr
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This resolves the issue on main where we are still using a legacy file upload plugin, causing an error and failing tests. I took the chance to migrate the global template settings to a Vue component, a start which I hope will lead to a cleanup of the admin settings in general, since everything is shoved into one large
AdminSettings.vuecomponent, and it's messy and difficult to reason about.TODO
Checklist