Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fix Admin Settings page when Watermark label selected #4124

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

Koc
Copy link
Contributor

@Koc Koc commented Oct 14, 2024

  • Target version: main

Summary

Reproducer:

  1. Open settings
  2. Enable watermark that will apply on files with some tags
  3. Refresh page

Expected result:
It is possible view and change tag that used for watermark assigning.

Actual result:
There is an error Error in render: "TypeError: option is undefined".
image

TODO

  • Backport to stable 29

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

@Koc Koc force-pushed the bugfix/fix-watermarks-for-labels branch from 74520b2 to 4fcbdcd Compare October 14, 2024 16:16
Copy link
Contributor

@elzody elzody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay, only one suggestion

lib/AppConfig.php Outdated Show resolved Hide resolved
@elzody elzody added the 2. developing Work in progress label Oct 14, 2024
@Koc Koc force-pushed the bugfix/fix-watermarks-for-labels branch from 4fcbdcd to 8440bad Compare October 14, 2024 20:52
@Koc Koc force-pushed the bugfix/fix-watermarks-for-labels branch from 8440bad to 428da1f Compare October 15, 2024 11:42
@elzody
Copy link
Contributor

elzody commented Oct 15, 2024

/backport to stable30

@elzody
Copy link
Contributor

elzody commented Oct 15, 2024

/backport to stable29

Copy link
Contributor

@elzody elzody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing tests are unrelated, looks good to me. Could not reproduce the original issue on stable28, so only backporting to stable29.

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants