Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Allow to opt-in loading image mimes on hide download shares #3137

Merged
merged 2 commits into from
Sep 1, 2023
Merged

fix: Allow to opt-in loading image mimes on hide download shares #3137

merged 2 commits into from
Sep 1, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Aug 24, 2023 •
edited
Loading

  • fix: Allow to opt-in loading image mimes on hide download shares
  • chore: Cleanup capabilities code
occ config:app:set richdocuments use_secure_view_additional_mimes --value=yes

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

@juliusknorr juliusknorr changed the title bugfix/noid/secure view mime option fix: Allow to opt-in loading image mimes on hide download shares Aug 24, 2023
@cypress
Copy link

cypress bot commented Aug 24, 2023 •
edited
Loading

Passing run #576 ↗︎

0 20 5 0 Flakiness 0

Details:

fix: Allow to opt-in loading image mimes on hide download shares
Project: Richdocuments Commit: ce3189663d
Status: Passed Duration: 02:51 💡
Started: Sep 1, 2023 9:38 AM Ended: Sep 1, 2023 9:41 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliusknorr juliusknorr force-pushed the bugfix/noid/secure-view-mime-option branch from 32f5879 to 97322ce Compare August 30, 2023 18:09
@juliusknorr juliusknorr force-pushed the bugfix/noid/secure-view-mime-option branch from 97322ce to ce31896 Compare September 1, 2023 09:31
@juliusknorr juliusknorr added bug Something isn't working 3. to review Ready to be reviewed labels Sep 1, 2023
@juliusknorr juliusknorr mentioned this pull request Sep 1, 2023
Open
7 tasks
@juliusknorr juliusknorr merged commit 0de6a1e into main Sep 1, 2023
46 checks passed
@juliusknorr juliusknorr deleted the bugfix/noid/secure-view-mime-option branch September 1, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luka-nextcloud luka-nextcloud luka-nextcloud approved these changes

Assignees
No one assigned
Labels
3. to review Ready to be reviewed bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliusknorr @luka-nextcloud